fix: rollout should skip timeout when paused

[wangli1030]

fix for issue #3534
Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
• The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
• I've signed my commits with DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My builds are green. Try syncing with master if they are not.

[github-actions]

Go Published Test Results

2 171 tests   2 171 ✅  2m 54s ⏱️
  119 suites      0 💤
    1 files        0 ❌

Results for commit b996a85.

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.86%. Comparing base (6ced7fc) to head (c024676).
Report is 15 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3711      +/-   ##
==========================================
- Coverage   83.87%   83.86%   -0.02%     
==========================================
  Files         163      163              
  Lines       18564    18564              
==========================================
- Hits        15571    15569       -2     
- Misses       2120     2121       +1     
- Partials      873      874       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

E2E Tests Published Test Results

  4 files    4 suites   3h 23m 50s ⏱️
111 tests 105 ✅  6 💤 0 ❌
444 runs  420 ✅ 24 💤 0 ❌

Results for commit b996a85.

♻️ This comment has been updated with latest results.

[wangli1030]

Hi @zachaller, could you help to review this PR? This issue really trouble us when user did not promote Rollouts in certain timeframe(progressDeadlineSeconds) and controller will mark it as timeout, hence ArgoCD will mark it as Sync Failed. Also in Rollout spec, it clearly states that # Note that progress will not be estimated during the time a rollout is paused.. Let me know if you need more proof on this. Thank you.

[zachaller]

Can you add a unit or e2e test for this?

[wangli1030]

Can you add a unit or e2e test for this?

Sure, will add it.

[github-actions]

Published E2E Test Results

  4 files    4 suites   3h 18m 4s ⏱️
113 tests 101 ✅  7 💤 5 ❌
460 runs  424 ✅ 28 💤 8 ❌

For more details on these failures, see this check.

Results for commit c024676.

♻️ This comment has been updated with latest results.

[github-actions]

Published Unit Test Results

2 277 tests   2 277 ✅  2m 59s ⏱️
  128 suites      0 💤
    1 files        0 ❌

Results for commit c024676.

♻️ This comment has been updated with latest results.

[wangli1030]

Hi @zachaller , UTs have been added. Please review it. Thank you.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[kishoregv]

Hey @zachaller,

I wanted to gently follow up on this pull request. I understand that you have many priorities to juggle, but I was hoping to get some feedback or an update on the status of this PR. If there are any changes or improvements needed, I'd be more than happy to address them.

Thank you for your time and consideration. I look forward to hearing from you.