feat(controller): add canary steps plugin #3521

agaudreault · 2024-04-10T13:42:25Z

Implementation of #3480
Related to #2685

Additional work

The following work can be done in subsequent pull request to facilitate the review of the feature

Create Official step plugin example with best practice in argoproj-labs
Configurable defaults for error, requeue and minRequeue.
Health status in ArgoCD should reflect the "cause"
ArgoCD UI extensions to add plugin step information
Run step plugin e2e on CI
Allow to reload config without restarting container
Documentation
- Explain step plugin behavior
- Explain configuration
- Example repository

Other

Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
I've signed my commits with DCO
I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
My builds are green. Try syncing with master if they are not.
My organization is added to USERS.md.

Signed-off-by: Alexandre Gaudreault <[email protected]>

github-actions · 2024-04-10T14:13:15Z

Go Published Test Results

2 241 tests 2 241 ✅ 2m 57s ⏱️
128 suites 0 💤
1 files 0 ❌

Results for commit 1fda169.

♻️ This comment has been updated with latest results.

github-actions · 2024-04-10T14:38:32Z

E2E Tests Published Test Results

4 files 4 suites 3h 27m 50s ⏱️
111 tests 98 ✅ 7 💤 6 ❌
466 runs 416 ✅ 28 💤 22 ❌

For more details on these failures, see this check.

Results for commit 1fda169.

♻️ This comment has been updated with latest results.

Signed-off-by: Alexandre Gaudreault <[email protected]>

codecov · 2024-04-18T15:28:13Z

Codecov Report

Attention: Patch coverage is 75.49801% with 123 lines in your changes missing coverage. Please review.

Project coverage is 84.04%. Comparing base (48131eb) to head (7459514).
Report is 68 commits behind head on master.

Files with missing lines	Patch %	Lines
rollout/steps/plugin/client/client.go	0.00%	44 Missing ⚠️
rollout/steps/plugin/resolver.go	9.09%	20 Missing ⚠️
rollout/stepplugin.go	86.71%	10 Missing and 9 partials ⚠️
rollout/steps/plugin/plugin.go	88.97%	10 Missing and 5 partials ⚠️
utils/plugin/types/steps.go	0.00%	9 Missing ⚠️
rollout/canary.go	50.00%	3 Missing and 1 partial ⚠️
utils/config/config.go	85.18%	2 Missing and 2 partials ⚠️
utils/plugin/plugin.go	63.63%	2 Missing and 2 partials ⚠️
rollout/steps/plugin/rpc/rpc.go	97.50%	1 Missing and 1 partial ⚠️
metricproviders/plugin/client/client.go	0.00%	1 Missing ⚠️
... and 1 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3521      +/-   ##
==========================================
- Coverage   84.23%   84.04%   -0.19%     
==========================================
  Files         154      161       +7     
  Lines       18022    18492     +470     
==========================================
+ Hits        15180    15541     +361     
- Misses       1999     2093      +94     
- Partials      843      858      +15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Alexandre Gaudreault <[email protected]>

agaudreault · 2024-05-01T15:32:06Z

test/e2e/step_plugin_test.go

+func (s *StepPluginSuite) SetupSuite() {
+	s.E2ESuite.SetupSuite()
+	if !IsStepPluginConfigured(&s.Common, s.GetControllerConfig()) {
+		s.T().SkipNow()


Should I configure E2E by default with a valid step plugin

I think we should but can do it, in a different PR.

Signed-off-by: Alexandre Gaudreault <[email protected]>

sonarqubecloud · 2024-05-07T13:26:38Z

Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

…plugin Signed-off-by: Zach Aller <[email protected]>

…plugin

github-actions · 2024-07-25T20:56:40Z

Published E2E Test Results

4 files 4 suites 3h 25m 45s ⏱️
112 tests 100 ✅ 7 💤 5 ❌
458 runs 420 ✅ 28 💤 10 ❌

For more details on these failures, see this check.

Results for commit 7459514.

♻️ This comment has been updated with latest results.

github-actions · 2024-07-25T20:56:46Z

Published Unit Test Results

2 257 tests 2 257 ✅ 2m 58s ⏱️
128 suites 0 💤
1 files 0 ❌

Results for commit 7459514.

♻️ This comment has been updated with latest results.

…plugin

Signed-off-by: Zach Aller <[email protected]>

sonarqubecloud · 2024-08-07T21:20:16Z

Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

agaudreault added 5 commits April 5, 2024 15:34

making code for step plugin

031a885

Signed-off-by: Alexandre Gaudreault <[email protected]>

Merge remote-tracking branch 'upstream/master' into step-plugin

78b42de

Signed-off-by: Alexandre Gaudreault <[email protected]>

Merge remote-tracking branch 'upstream/master' into step-plugin

0d4da53

Signed-off-by: Alexandre Gaudreault <[email protected]>

codegen

fc18d4b

Signed-off-by: Alexandre Gaudreault <[email protected]>

unit tests

2d0513d

Signed-off-by: Alexandre Gaudreault <[email protected]>

agaudreault added 14 commits April 10, 2024 11:21

rpc tests

da408a0

Signed-off-by: Alexandre Gaudreault <[email protected]>

add rpc plugin tests

2169e35

Signed-off-by: Alexandre Gaudreault <[email protected]>

better message

c76da2d

Signed-off-by: Alexandre Gaudreault <[email protected]>

add order test

e61ca78

Signed-off-by: Alexandre Gaudreault <[email protected]>

implement terminate

129ff0c

Signed-off-by: Alexandre Gaudreault <[email protected]>

Terminate tests

b610112

Signed-off-by: Alexandre Gaudreault <[email protected]>

aborted logic + some unit test

0db60ea

Signed-off-by: Alexandre Gaudreault <[email protected]>

unit test

67e1f32

Signed-off-by: Alexandre Gaudreault <[email protected]>

abort test

37171bd

Signed-off-by: Alexandre Gaudreault <[email protected]>

load plugin

c6e2a98

Signed-off-by: Alexandre Gaudreault <[email protected]>

more tests

790bc1b

Signed-off-by: Alexandre Gaudreault <[email protected]>

dont use newStatus

c25ce26

Signed-off-by: Alexandre Gaudreault <[email protected]>

codegen preserve fields

5ed7955

Signed-off-by: Alexandre Gaudreault <[email protected]>

some test before full promote problem

a0c30c9

Signed-off-by: Alexandre Gaudreault <[email protected]>

agaudreault added 8 commits April 18, 2024 12:05

fix full promotion

db17cb5

Signed-off-by: Alexandre Gaudreault <[email protected]>

fix plugins

5dedcc2

Signed-off-by: Alexandre Gaudreault <[email protected]>

codegen

ce17794

Signed-off-by: Alexandre Gaudreault <[email protected]>

add disabled rollout

0cc4d71

Signed-off-by: Alexandre Gaudreault <[email protected]>

codegen

c007efa

Signed-off-by: Alexandre Gaudreault <[email protected]>

fix duration cast

dfeab0b

Signed-off-by: Alexandre Gaudreault <[email protected]>

refactor to use context object

bcb39ad

Signed-off-by: Alexandre Gaudreault <[email protected]>

adding debug logs.

dcc9d93

Signed-off-by: Alexandre Gaudreault <[email protected]>

agaudreault added 2 commits May 1, 2024 10:38

unit tests

9d81110

Signed-off-by: Alexandre Gaudreault <[email protected]>

more test

c776330

Signed-off-by: Alexandre Gaudreault <[email protected]>

agaudreault commented May 1, 2024

View reviewed changes

agaudreault added 5 commits May 1, 2024 11:44

cleanup

aa37238

Signed-off-by: Alexandre Gaudreault <[email protected]>

add docs

4866c0c

Signed-off-by: Alexandre Gaudreault <[email protected]>

docs

d8b5171

Signed-off-by: Alexandre Gaudreault <[email protected]>

Merge remote-tracking branch 'upstream/master' into step-plugin

2a05ea0

makefile for e2e

a4331ab

Signed-off-by: Alexandre Gaudreault <[email protected]>

agaudreault marked this pull request as ready for review May 1, 2024 21:28

agaudreault requested a review from zachaller May 1, 2024 21:29

agaudreault changed the title ~~feat(canary): define steps as plugins~~ feat(controller): define steps as plugins May 1, 2024

agaudreault changed the title ~~feat(controller): define steps as plugins~~ feat(controller): add canary steps plugin May 1, 2024

agaudreault added 3 commits May 1, 2024 17:38

disable e2e when not configured

ee5195b

Signed-off-by: Alexandre Gaudreault <[email protected]>

Add some UI for the extension

b1d0963

Signed-off-by: Alexandre Gaudreault <[email protected]>

Merge branch 'master' into step-plugin

1fda169

zachaller added 2 commits July 25, 2024 11:52

Merge branch 'master' of github.com:argoproj/argo-rollouts into step-…

1a20837

…plugin Signed-off-by: Zach Aller <[email protected]>

Merge branch 'master' of github.com:argoproj/argo-rollouts into step-…

8bb0feb

…plugin

Merge branch 'master' of github.com:argoproj/argo-rollouts into step-…

ef48f19

…plugin

zachaller mentioned this pull request Aug 5, 2024

Synchronization barrier for deploying to multiple clusters in parallel #3770

Open

zachaller added 3 commits August 5, 2024 12:50

Merge branch 'master' of github.com:argoproj/argo-rollouts into step-…

941e8e0

…plugin

Merge branch 'master' of github.com:argoproj/argo-rollouts into step-…

be995fb

…plugin

codegen

7459514

Signed-off-by: Zach Aller <[email protected]>

zachaller added this to the v1.8 milestone Aug 8, 2024

zachaller approved these changes Aug 8, 2024

View reviewed changes

zachaller merged commit 74c1a94 into argoproj:master Aug 8, 2024
22 of 25 checks passed

agaudreault mentioned this pull request Oct 19, 2024

docs: document canary step plugin (alpha) #3906

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(controller): add canary steps plugin #3521

feat(controller): add canary steps plugin #3521

agaudreault commented Apr 10, 2024 •

edited

Loading

github-actions bot commented Apr 10, 2024 •

edited

Loading

github-actions bot commented Apr 10, 2024 •

edited

Loading

codecov bot commented Apr 18, 2024 •

edited

Loading

agaudreault May 1, 2024

zachaller Jul 25, 2024

sonarqubecloud bot commented May 7, 2024

github-actions bot commented Jul 25, 2024 •

edited

Loading

github-actions bot commented Jul 25, 2024 •

edited

Loading

sonarqubecloud bot commented Aug 7, 2024

feat(controller): add canary steps plugin #3521

feat(controller): add canary steps plugin #3521

Conversation

agaudreault commented Apr 10, 2024 • edited Loading

Additional work

Other

github-actions bot commented Apr 10, 2024 • edited Loading

Go Published Test Results

github-actions bot commented Apr 10, 2024 • edited Loading

E2E Tests Published Test Results

codecov bot commented Apr 18, 2024 • edited Loading

Codecov Report

agaudreault May 1, 2024

Choose a reason for hiding this comment

zachaller Jul 25, 2024

Choose a reason for hiding this comment

sonarqubecloud bot commented May 7, 2024

Quality Gate failed

github-actions bot commented Jul 25, 2024 • edited Loading

Published E2E Test Results

github-actions bot commented Jul 25, 2024 • edited Loading

Published Unit Test Results

sonarqubecloud bot commented Aug 7, 2024

Quality Gate failed

agaudreault commented Apr 10, 2024 •

edited

Loading

github-actions bot commented Apr 10, 2024 •

edited

Loading

github-actions bot commented Apr 10, 2024 •

edited

Loading

codecov bot commented Apr 18, 2024 •

edited

Loading

github-actions bot commented Jul 25, 2024 •

edited

Loading

github-actions bot commented Jul 25, 2024 •

edited

Loading