Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate whether there exists a 3rd-party equivalent to our Logger type #6056

Closed
glasser opened this issue Jan 26, 2022 · 1 comment · Fixed by #6299
Closed

Investigate whether there exists a 3rd-party equivalent to our Logger type #6056

glasser opened this issue Jan 26, 2022 · 1 comment · Fixed by #6299
Assignees
Milestone

Comments

@glasser
Copy link
Member

glasser commented Jan 26, 2022

Our Logger type is just a basic TS interface (with default implementation provided by the loglevel npm package) for a error/warning/etc thing. We allow folks to pass in any matching implementation and have some tests that show it's possible to use this with winston, bunyan, log4js, and loglevel. We should take at least a moment to see if there's some existing package out there (perhaps just loglevel which is a dependency already) that lets us define this TS type in a way that is compatible with all those implementations without us having to export ourself. (This is part of #FIXME)

@trevor-scheer
Copy link
Member

Proposing this, which will also be useful to gateway.
apollographql/apollo-utils#55

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants