Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐘 Gradle config: mandate service name #4516

Closed
martinbonnin opened this issue Nov 18, 2022 · 1 comment
Closed

🐘 Gradle config: mandate service name #4516

martinbonnin opened this issue Nov 18, 2022 · 1 comment

Comments

@martinbonnin
Copy link
Contributor

In version 3.7.0 and below, it is possible to use a default service:

apollo {
  packageName.set("com.example")
}

While this is working and easy, this has 2 drawbacks:

  1. it forces one afterEvaluate {} in the Gradle plugin code which makes the behaviour reliant on the ordering of other plugins and is error prone
  2. as we move to more build time codegen, we will generate code based on the service name so making the user aware of that name will make things more explicit and less magic (see Automatic adapters registration #4515)
@martinbonnin
Copy link
Contributor Author

Done in main

@martinbonnin martinbonnin changed the title 🐘 Gradle config: mandate service name? 🐘 Gradle config: mandate service name Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant