Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming of getters/get_ prefix #4

Open
virtualritz opened this issue Jan 9, 2025 · 1 comment
Open

Naming of getters/get_ prefix #4

virtualritz opened this issue Jan 9, 2025 · 1 comment

Comments

@virtualritz
Copy link

Rust naming conventions state that getters do not have a get_ prefix but all/most getters in this crate do.

Would you accept a PR that fixed this? Including deprecation warnings on the old signatures, ofc.
@anuejn
Copy link
Member

anuejn commented Jan 10, 2025

Yes, that would be great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@virtualritz @anuejn