Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Inconsistent function signature of NDarray.randn #12801

Open
ChaiBapchya opened this issue Oct 11, 2018 · 3 comments
Open

Inconsistent function signature of NDarray.randn #12801

ChaiBapchya opened this issue Oct 11, 2018 · 3 comments
Labels

Comments

@ChaiBapchya
Copy link
Contributor

ChaiBapchya commented Oct 11, 2018

Description

NDArray.randn function signature
def rand (*shape, **kwargs):
is incorrect and inconsistent with rest of the signatures in Random Number Generator NDArray API

a. Rest of the parameters - loc, scale, shape, dtype, ctx, out need to be included
b. *shape has to be replaced by shape
c. Why is another level of abstraction added by putting everything in **kwargs and then popping it up. If that's required, why not for others?

@anirudhacharya
Copy link
Member

can you please add links and references in the above issue description

@piyushghai
Copy link
Contributor

Thank you for reporting this issue @ChaiBapchya
@mxnet-label-bot [NDArray]

@ChaiBapchya
Copy link
Contributor Author

Yup, I'm working on another PR that will have fix for this too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants