-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Observations on a Scrolling Bug #90
Comments
Thanks for the report! this is definitely on the roadmap for fixing this summer during GSOC. |
Great—thank you! 🐈 |
Hi @ampurr, thanks for really breaking down the 'How do you stop it from happening?' part. I've made some tweaks to the JS code for the selection menu and it seems to have solved the issue on my side. Could you give it a spin and see if it works for you too? |
Thanks! It's the weekend, so I'll take a look at it later. Super appreciate it. 🌈🐱 |
@Faye-yufan, I finally got a chance to test it. Thanks for your work—it works! :> There's still a very minor bug remaining, but for most practical purposes the bug has been fixed [1]. 🌱 [1] What's the minor bug? It's this: Given a set of animints |
Hey @ampurr thanks for your analysis of the minor bug. Would it be possible/easy to write a test case that fails for that minor bug with the current code? |
@tdhock: To be honest, I don't know! My initial thought was no, but then I did a little bit of research and now it's a maybe. Why the Initial NoThe most obvious difficulty is that both the major and minor bugs only appear through interaction. For example, the minor bug only comes out when:
Since the particulars of the viewport are part of the bug, I'm not sure how we could automate testing. We'd need to automate doing things like scrolling through a webpage and have the tester somehow notice when it isn't scrolling right. Why the Current MaybeAutomated testing may be more sophisticated than I first thought. For example, ConclusionI think it's probably possible, but it won't be easy. (For me, anyway—you're much more competent than I am.) A large part of that is because I'll need time to learn how to do things with |
Hi @ampurr thank you for the feedback and thorough analysis! I appreciate it. Regarding the test case, I encountered a difficulty on my end. I cannot reproduce the bug because I don't have the code or command line for generating the animint manual, and I noticed that you built it using |
to generate a chapter of the animint manual, this script uses an old version of bookdown::render with html_chapter() https://github.com/tdhock/animint-book/blob/master/_plugins/knit.R |
Got it thank you, will try! |
@Faye-yufan: Sorry, I'm a little confused. Toby built the animint2 Manual, not me. 😅 Where You may be Referring ToYou may be referring to the preliminary animint2 reference website I built using The bugs show up on my exam. Is that what you're referring to? If you are:
Reproducing Big Bug and Little BugAs you know, Big Bug is easy to reproduce in Big Bug House. Jump to the bottom of the page and watch it scroll up. You fixed this one. 🐈 Little Bug House's bug is subtler. You can reproduce it like this:
Hope this helps. Thank you again! :> |
In Firefox, the selector widget ( |
@Faye-yufan, thanks for noticing the I experimented with .table_selector_widgets {
overflow: whatever;
} but changing Furthermore, I'm not sure why Firefox is saying that the element is overflowing while other browsers like Edge aren't. It sure looks like both But if I'm right, then the problem unfortunately isn't overflowing content. 😖 [1] I also tried playing around with a child element of the overflowing element: .foobar_variable_selector_widget {
overflow: whatever;
} Didn't work. 😔 |
It might have something to do with browser support for certain CSS elements, though. In fact, that seems to be the most plausible explanation and I'm embarrassed I didn't think of it till now. I originally thought the most plausible explanation was Firefox-exclusive JS stuff. |
Did some testing. I thought it might've been |
Apparently it's to fix an Internet Explorer bug. 🔵 |
The Bug
In Firefox (but not in Edge), there's a curious scrolling bug where some webpages with some animints scroll up by themselves. It's like the webpage is possessed by an especially boring ghost.
You can experience it for yourself. Open Chapter 7 in the
animint2
Manual in Firefox, scroll all the way down, and watch the webpage just slowly scroll up by itself.Since it's browser-dependent, I'm actually not sure that this counts as a bug for
animint2
instead of, say, Firefox. But this seemed to be the best place to document it, and I wanted to write down my observations before I forget them.When Does the Bug Happen?
It seems to become visible when all these criteria are met:
The Fix
How do you stop it from happening? Either:
What's the Cause?
The scrolling seems to happen every time the selected value/s change. The quicker they change, the quicker the scrolling. The more they are, the faster the scrolling occurs. When they stop changing, the scrolling stops, too. Furthermore, the bug doesn't show itself on all browsers.
Therefore, it seems reasonable to conclude that the scrolling bug is caused by some combination of browser contribution and either:
The text was updated successfully, but these errors were encountered: