Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ANDROID_ARM_MODE behavior change between legacy and new toolchain file #1656

Closed
DanAlbert opened this issue Jan 18, 2022 · 1 comment
Closed
Assignees
Labels

Comments

@DanAlbert
Copy link
Member

Description

Mirroring https://gitlab.kitware.com/cmake/cmake/-/issues/23108 for tracking purposes.

The legacy toolchain would ignore the -DANDROID_ARM_MODE argument if it was passed for any ABI other than armeabi-v7a. The new toolchain converts that to CMAKE_ANDROID_ARM_MODE, and CMake 3.22 emits an error if that is passed for ABIs other than armeabi-v7a. We should preserve the old behavior.

@hhb has already uploaded a fix for us (thanks!): https://android-review.googlesource.com/c/platform/ndk/+/1951676

Affected versions

r23, r24

Canary version

No response

Host OS

Linux, Mac, Windows

Host OS version

All

Affected ABIs

arm64-v8a, x86, x86_64

Build system

CMake

Other build system

No response

minSdkVersion

Any

Device API level

No response

@DanAlbert
Copy link
Member Author

Should be fixed in r23 build 8486889.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants