Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to java 8 and update dependencies #369

Closed
aleksandr-m opened this issue Nov 13, 2022 · 5 comments
Closed

Move to java 8 and update dependencies #369

aleksandr-m opened this issue Nov 13, 2022 · 5 comments

Comments

@aleksandr-m
Copy link
Owner

No description provided.

@DRoppelt
Copy link
Contributor

if java8 becomes the baseline, the plugin versions pinned with this can be pulled up to more recent versions: #330

for instance, versions-maven-plugin with 2.8.1 from 2010 pulls in strutsv1 (which we in our org noticed as the mvn-repositury was flaggen on our build nodes)

image

@DRoppelt
Copy link
Contributor

DRoppelt commented Feb 8, 2023

The latest maven release, 3.9.0, now also has Java 8 as baseline https://maven.apache.org/docs/3.9.0/release-notes.html

Minimum Java version to use with Maven 3.9.0 is raised to Java 8.

I wanted to check if the project & its testcases work with maven 3.9.0, but are not runnable due to that change. I will prepare a PR for java8 but I am not offended if it lays around for a while.

@DRoppelt
Copy link
Contributor

DRoppelt commented May 2, 2023

I got stuck for a while since the tests kept being red, I missed that this has changed meanwhile 3327fb5 this was not related, nvm

PR is in progress

@DRoppelt
Copy link
Contributor

DRoppelt commented Jun 1, 2023

Now that 1.20.0 is released... what do you think about bringing this ticket/PR into the next release? And if so, when?

I think that you mentioned that this ticket was more for intent than actually working on it in november. With the change of maven 3.9.X having java 8 as minimum version (https://maven.apache.org/docs/3.9.0/release-notes.html), it feels like this is something that can be introduced in your plugin too?

@aleksandr-m
Copy link
Owner Author

Done.

@aleksandr-m aleksandr-m unpinned this issue Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants