endpoint.py line 307: TypeError: init() got an unexpected keyword argument 'verify_ssl'

[noahbenson]

Describe the bug
I received this bug report for a library I maintain that uses s3fs, which in its recent version uses aiobotocore. I have traced the error to what appears to be a clear problem in the source code: this line passes the keyword argument verify_ssl to the aiohttp.TCPConnector constructor. However, the keyword is not valid in the aiohttp source code. It looks to me at first glance that the verify_ssl keyword argument was changed to just ssl but it hasn't been changed in the aiobotocore library.

I have not attempted to reproduce this bug myself, but given how straightforward it appears to be, I thought it was worth filing the bug report anyway. If this appears to be something else, then @rickvanhoof may be able to provide context for the failure.

Checklist

• I have reproduced in environment where pip check passes without errors
• I have provided pip freeze results
• I have provided sample code or detailed way to reproduce
• I have tried the same code in botocore to ensure this is an aiobotocore specific issue
• I have tried similar code in aiohttp to ensure this is is an aiobotocore specific issue
• I have checked the latest and older versions of aiobotocore/aiohttp/python to see if this is a regression / injection

pip freeze results

Environment:

• Python Version: 3.8.9
• OS name and version: Ubuntu 18.04.5

Additional context
noahbenson/neuropythy#20

[thehesiod]

Thanks, will look asap if someone else doesn't get to it before me

[thehesiod]

going to handle this in #856

[thehesiod]

verify_ssl and ssl_context are still valid in the latest release: https://github.com/aio-libs/aiohttp/blob/3.7/aiohttp/connector.py#L740

[thehesiod]

actually I think this is not a bug, we're using aiohttp 3.7.4.post0 w/ the most recent aiobotocore w/o issue. I think maybe you were testing with a master release of aiohttp and not official release

[noahbenson]

I see—the bug report from @rickvanhoof didn't show the aiohttp version so this seems plausible—perhaps he is/was using another library that depended on a non-official version.

Thanks for looking into this so quickly—if I see any more like this I'll be sure to ask for the pip freeze.

[thehesiod]

closing since we now test with 3.7.4.post0 and it works fine. Please re-open when you have more information