Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Universal2 versions of python for use with PyInstaller #271

Closed
cmot17 opened this issue Nov 16, 2021 · 6 comments
Closed

Add Universal2 versions of python for use with PyInstaller #271

cmot17 opened this issue Nov 16, 2021 · 6 comments
Labels
feature request New feature or request to improve the current logic

Comments

@cmot17
Copy link

cmot17 commented Nov 16, 2021

Description:
https://pyinstaller.readthedocs.io/en/stable/feature-notes.html#macos-multi-arch-support
I believe that PyInstaller supports creating universal2 binaries for MacOS from an x86 machine - it just needs to be running the universal2 version of python.
Justification:

This would be really useful to build apps compatible with Apple Silicon.

@cmot17 cmot17 added feature request New feature or request to improve the current logic needs triage labels Nov 16, 2021
@nikita-bykov
Copy link
Contributor

Hello @cmot17! Thanks for your feature request. We will look at it.

@nikita-bykov
Copy link
Contributor

Hey @cmot17!
The same feature request already exists in the virtual-environment repository: Add universal2 builds of Python to actions/setup-python #4133.
The PR is also open for it: Compile in universal2 mode for macOS Python >= 3.9.1. #114.
You can find more context in the links above.

@rtibbles
Copy link

PR actions/python-versions#114 was merged and then reverted a month later with actions/python-versions#175, so this issue could still do with being resolved.

As it seems that some were unhappy with this being the default behaviour, it would be useful if this could be an optional flag for setup-python on MacOS runners.

@albertosottile
Copy link

albertosottile commented Aug 22, 2022

I can confirm that this is still an outstanding issue (after the revert performed in actions/python-versions#175). Please consider this feature as its lack is preventing developers from building universal2 wheels and projects, which is what Apple recommends.

@albertosottile
Copy link

Further reasons for this need can be found in the original issue here: actions/runner-images#4133 This issue was closed when the feature was originally implemented, but not reopened when it was reverted.

@IvanZosimov
Copy link
Contributor

IvanZosimov commented Nov 16, 2022

Hi, @cmot17 👋 Starting from the Python 3.11.0-rc.2 the setup-python action installs official universal2 for macOS, so the feature you requested is implemented.

Now, I'm going to close this issue, If you have any additional questions feel free to ping us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

5 participants