Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unterminated regular expression for valid code containing division #727

Closed
fdietze opened this issue Sep 7, 2018 · 1 comment
Closed

Unterminated regular expression for valid code containing division #727

fdietze opened this issue Sep 7, 2018 · 1 comment
Labels
bug

Comments

@fdietze
Copy link

fdietze commented Sep 7, 2018

[email protected]

$ echo 'f(a/b,a/b,a.of/b)' | acorn --ecma6
Unterminated regular expression (1:15)

The slashes are division, not a regular expression.

ecma3 to ecma5 work well, while from ecma6 the error occurs.
@RReverser RReverser added the bug label Sep 7, 2018
@marijnh marijnh closed this as completed in 0c12f63 Sep 7, 2018
@marijnh
Copy link
Member

marijnh commented Sep 7, 2018

That was an issue in the tokenizer. Attached patch should resolve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marijnh @RReverser @fdietze