Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltips Hidden by Formatting Toolbar #87

Closed
jolanglinais opened this issue May 15, 2020 · 10 comments · Fixed by #268
Closed

Tooltips Hidden by Formatting Toolbar #87

jolanglinais opened this issue May 15, 2020 · 10 comments · Fixed by #268

Comments

@jolanglinais
Copy link
Member

jolanglinais commented May 15, 2020

Bug Report 🐛

Tooltips for conditional variables and clause template action icons (test, edit, delete) are hidden behind the formatting toolbar

Expected Behavior

Tooltips should be above everything else

Current Behavior

Screen Shot 2020-05-15 at 10 06 36 AM

Possible Solution

Raise the z-index of these components

Steps to Reproduce

  1. View the demo
  2. Place cursor after the clause template, create new lines until sufficient scrolling
  3. Scroll to make the action icons just below the formatting toolbar
  4. Hover and see them hidden under the toolbar

Context (Environment)

Desktop

  • OS: macOS
  • Browser: Chrome
  • Version: 0.91.0
@jolanglinais
Copy link
Member Author

Also seen in this reproduction is the formatting toolbar width issue?

@arteevraina
Copy link

@irmerk Can I take a look at this?

@shubhamkakkar
Copy link

@irmerk I am planning to look into this.

  1. the demo link you addded in the description doesnt works
  2. can you guide me to the exact component, I am new to the projec so dont have much idea;

@jolanglinais
Copy link
Member Author

Sorry about that @shubhamkakkar I updated the demo link - it was before we moved back to Netlify. Yes so these tooltips are located here in the Clause component, that should be your starting point.

@dselman
Copy link
Contributor

dselman commented Feb 10, 2021

@DianaLease is this now fixed with the z-index changes?

@jolanglinais
Copy link
Member Author

I believe the changes we mentioned during the Working Group call were in relation to the buttons on a clause, not the formatting toolbar.

@DianaLease
Copy link
Member

@dselman @irmerk It's still an issue, but not as bad as the screenshot in the original post as we have changed the toolbar since then. Here's an updated screenshot:
Screen Shot 2021-02-11 at 3 46 47 PM

@Udbhavbisarya23
Copy link
Contributor

@DianaLease @irmerk @dselman If this is still an issue, can i be assigned to this?

@Udbhavbisarya23
Copy link
Contributor

The z-index of the tooltip is 99 and that of the toolbar is 10.
I believe this issue can be fixed by removing the z-index of the formatting toolbar or by adding a position and z-index property to the text editor.

@jolanglinais
Copy link
Member Author

Hmm, unsure why the toolbar would need an index, I don't think it will need to be on top of anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants