Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to drag and drop a clause template into a list #157

Closed
Michael-Grover opened this issue Jul 23, 2020 · 6 comments · Fixed by #231
Closed

Possible to drag and drop a clause template into a list #157

Michael-Grover opened this issue Jul 23, 2020 · 6 comments · Fixed by #231

Comments

@Michael-Grover
Copy link

Bug Report 🐛

It's possible to drag and drop a clause template into a bulleted list or numbered list

Expected Behavior

when dragging a clause template into a list, the clause template should be placed outside of the list rather than becoming part of the list

Current Behavior

When a user drags a clause template onto a bulleted list or numbered list, the clause template appears to become the first element of the list, with a bullet in front of it.

image
image

video
https://www.loom.com/share/4b53763bf2544879854bc2ac3da63eea

@sanketshevkar
Copy link
Member

Hey is this bug solved? I'll like to work on this issue.

@Michael-Grover
Copy link
Author

@sanketshevkar it looks like this bug hasn't been solved. I've assigned it to you. Thanks for volunteering! I am not an engineer, so if you have any questions about this bug, they should be directed towards @DianaLease, @irmerk, or another code maintainer.

@sanketshevkar
Copy link
Member

@Michael-Grover Okay sure.

@sanketshevkar
Copy link
Member

@Michael-Grover is there any use case wherein you'll be needing a list of clauses?

@Michael-Grover
Copy link
Author

@sahalsaad No, I don't think so. @jeromesimeon could probably answer that question more accurately. He is busy today, but may be able to respond tomorrow.

@sanketshevkar
Copy link
Member

@Michael-Grover I've added a pull request for this issue. I've added both behaviours, adding clause inside as well as outside a list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants