Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the preview headings in the style dropdown reflect the style of those headings #103

Closed
Michael-Grover opened this issue May 22, 2020 · 1 comment · Fixed by #143
Closed

Comments

@Michael-Grover
Copy link

Michael-Grover commented May 22, 2020

Discussion 🗣

Currently the heading previews in the style dropdown do not reflect the actual appearance of headings when they are added in the contract text. These previews should give the user an accurate preview of what the heading should look like in the document.

This should remain so even when people who extend this component change the heading styles for their particular apps. They should be linked so if the heading styling changes, the preview of it in the styling dropdown changes too. So when if change the heading styling to be sans-serif instead of a serif font, the dropdown should ideally reflect that.

Current:
image

doesn't match headings in text:
image

@conste11ations
Copy link
Contributor

Hi! I created a pull request in hopes this helps you with the issue you have raised. Took a stab at assuming how people would ideally extend these components (assumed the constants would be updated because there are default styles already there), please let me know if incorrect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants