Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

license detection: Add the nunit license #2859

Open
fviernau opened this issue Feb 8, 2022 · 1 comment
Open

license detection: Add the nunit license #2859

fviernau opened this issue Feb 8, 2022 · 1 comment

Comments

@fviernau
Copy link
Contributor

fviernau commented Feb 8, 2022

Scanning the nunit license [2] via [1] results in a couple of generic license findings, with ScanCode version 31.1.0, which match only parts of the license text. Add a separate license identifier for that license along with detection capabilities.

[1] https://github.com/apache/avro/blob/6b55656b25cacf0d88cf44d9d802ce46dfaadc83/LICENSE.txt#L312-L345
[2] https://docs.nunit.org/2.6/license.html

@pombredanne
Copy link
Member

Thanks for the report!
The latest develop returns something as:

license_expressions:
    - zlib-acknowledgement
    - zlib-acknowledgement
    - zlib

and we should really get only

license_expressions:
    - zlib-acknowledgement
    - zlib-acknowledgement

or just one of these.
Nunit --if I recall correctly-- has a long history (with ScanCode) because of the injection of copyright in the middle of the license text. I have added a note in #2878 too, and your input would mean a lot there too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants