Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatible with go.opentelemetry.io/otel/metric v0.35.0 #138

Closed
hairyhenderson opened this issue Jan 31, 2023 · 2 comments
Closed

Incompatible with go.opentelemetry.io/otel/metric v0.35.0 #138

hairyhenderson opened this issue Jan 31, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@hairyhenderson
Copy link

hairyhenderson commented Jan 31, 2023 •
edited
Loading

Description

When upgrading an application's dependency go.opentelemetry.io/otel/metric to v0.35.0, this module fails to compile. I see that this PR removed some packages that are used here: open-telemetry/opentelemetry-go#3530

Environment

  • OS: n/a
  • Architecture: n/a
  • Go Version: n/a
  • otelsql version: v0.17.1

Steps To Reproduce

  1. See Bump go.opentelemetry.io/otel from 1.11.2 to 1.12.0 #137, for example

Expected behavior

otelsql should compile
@hairyhenderson hairyhenderson added the bug Something isn't working label Jan 31, 2023
@XSAM
Copy link
Owner

XSAM commented Feb 1, 2023

Thank you @hairyhenderson for raising this issue.

I have upgraded the otel library. Please check https://github.com/XSAM/otelsql/releases/tag/v0.18.0

@hairyhenderson
Copy link
Author

Awesome! thanks @XSAM 🙇‍♂️

@XSAM XSAM closed this as completed Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hairyhenderson @XSAM