Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacer block: unlabeled Range and Input controls #63800

Closed
2 tasks done
afercia opened this issue Jul 22, 2024 · 0 comments · Fixed by #63806
Closed
2 tasks done

Spacer block: unlabeled Range and Input controls #63800

afercia opened this issue Jul 22, 2024 · 0 comments · Fixed by #63806
Assignees
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Block editor /packages/block-editor [Package] Block library /packages/block-library [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Jul 22, 2024

Description

The Spacer block can be used to add vertical or horizontal spacing.

In both cases, two settings controls are unlabeled. One more case of completely unlabeled controls only because the label prop is not required or used incorrectly. Cc @WordPress/gutenberg-components @joedolson

Vertical spacing:
The range control highlighted in the screenshot below is unlabaled:

Screenshot 2024-07-22 at 12 51 45

Horizontal spacing:
The input field highlighted in the screenshot below is unlabaled:

Screenshot 2024-07-22 at 12 51 39

Step-by-step reproduction instructions

  • Add a Row with a paragraph, a spacer block and another paragraph
  • Select the spacer.
  • Inspect the width input control when the width is set to 'fixed'.
  • Observe the input field is not labeled.
  • Add a normal Spacer block and select it.
  • Inspect the width range control.
  • Observe it's not labeled.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes
@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Block library /packages/block-library labels Jul 22, 2024
@afercia afercia self-assigned this Jul 22, 2024
@afercia afercia added the [Package] Block editor /packages/block-editor label Jul 22, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Block editor /packages/block-editor [Package] Block library /packages/block-library [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant