Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspector: Polish "Link" button / dialog for static homepage #62065

Closed
jameskoster opened this issue May 28, 2024 · 5 comments · Fixed by #62279
Closed

Inspector: Polish "Link" button / dialog for static homepage #62065

jameskoster opened this issue May 28, 2024 · 5 comments · Fixed by #62279
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

Here's the Link button / dialog for regular pages:

Screenshot 2024-05-28 at 13 24 13

Here it is for a static homepage:

Screenshot 2024-05-28 at 13 23 58

The button label shows the slug, but the dialog shows only the TLD with no edit-ability. In the case of the homepage, there's very little value in allowing users to change the slug, and it could lead to confusion.

  • Should the Link row be hidden entirely for the static homepage?
  • Or should it simply list the TLD as an externallink?
Screenshot 2024-05-28 at 13 28 17
@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. labels May 28, 2024
@jameskoster jameskoster added the [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") label May 28, 2024
@jorgefilipecosta jorgefilipecosta self-assigned this May 28, 2024
@jorgefilipecosta
Copy link
Member

Hi @jameskoster,

I like the option "Or should it simply list the TLD as an externallink" but the homepage URL may be huge and may not fit a row. Maybe we show the link until a certain number of chars that fit, and after that we show "Homepage" with the link symbol and linking to the homepage. Would that work?

@jameskoster
Copy link
Contributor Author

@jorgefilipecosta there's a PR to unify the behavior of these buttons here: #61954. It's probably okay if they wrap for now, we can apply unique treatments to specific buttons later.

and after that we show "Homepage" with the link symbol and linking to the homepage.

There's a separate PR to indicate the homepage here: #62071, so we probably don't need the extra affordance in the Link row.

"Or should it simply list the TLD as an externallink"

Maybe we start just with this?

@colorful-tones
Copy link
Member

With WordPress 6.6 Beta 1 targeted to be released in less than a day - Editor Triage Leads will move this to Punted to 6.6.1 for now.

@colorful-tones colorful-tones moved this from 📥 Todo to 🐛 Punted to 6.6.1 in WordPress 6.6 Editor Tasks Jun 3, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 4, 2024
@jorgefilipecosta
Copy link
Member

Hi @colorful-tones, I think this fix can still go with WordPress 6.6, the fact that for frontpages we are showing the wrong link can be seen as a bug.

@jorgefilipecosta jorgefilipecosta added [Type] Bug An existing feature does not function as intended [Type] Enhancement A suggestion for improvement. and removed [Type] Enhancement A suggestion for improvement. labels Jun 4, 2024
@colorful-tones colorful-tones moved this from 🐛 Punted to 6.6.1 to 📥 Todo in WordPress 6.6 Editor Tasks Jun 4, 2024
@colorful-tones
Copy link
Member

I think this fix can still go with WordPress 6.6, the fact that for frontpages we are showing the wrong link can be seen as a bug.

Thanks for clarifying @jorgefilipecosta. I've triaged this back to the ToDo column. Does this still need the Needs design feedback label, as I see you have an active pull request already in progress, and it seems odd that it would classified as a Bug and an Enhancement, but I'm probably being too stringent. 😅

@colorful-tones colorful-tones moved this from 📥 Todo to 🏗️ In Progress in WordPress 6.6 Editor Tasks Jun 4, 2024
@github-project-automation github-project-automation bot moved this from Now to Done in Design priorities Jun 5, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to ✅ Done in WordPress 6.6 Editor Tasks Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Enhancement A suggestion for improvement.
Projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants