Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish design of edit interfaces for meta in page inspector #60291

Closed
5 tasks done
jameskoster opened this issue Mar 28, 2024 · 10 comments
Closed
5 tasks done

Polish design of edit interfaces for meta in page inspector #60291

jameskoster opened this issue Mar 28, 2024 · 10 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

jameskoster commented Mar 28, 2024

As a part of the work in #59689 it would be nice to tidy up the edit interface for page meta data. These UIs looking a little rough around the edges, and the designs in 59689 call for some options like discussion and parent selection to move into the Summary panel.

Here's the current state of affairs:

current-panels

@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. Needs Design Needs design efforts. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Mar 28, 2024
@jameskoster
Copy link
Contributor Author

Status panel is being worked on in #60456.

@jameskoster
Copy link
Contributor Author

Mockups for the other panels:

Screenshot 2024-04-04 at 14 40 25

@ntsekouras
Copy link
Contributor

@jameskoster what about the pingbacks & trackbacks in posts? How do they fit with the comments setting? You can see the current checkbox in post editor in posts.

@jameskoster
Copy link
Contributor Author

It could live in the discussion popover as a checkbox for now, I suppose that would be least disruptive. But it might be too prominent there – seems like a setting more likely to be configured at the global level, and rarely overridden locally. We could consider placing it in the ellipsis menu down the road:

Screenshot 2024-04-10 at 09 47 03

@ntsekouras
Copy link
Contributor

ntsekouras commented Apr 10, 2024

It could live in the discussion popover as a checkbox for now,

What about the label of the button though? It can't just say comments open/closed, right?

Also there is the possibility that we only have the trackbaacks checkbox available and not the comments, if the post type supports only that..

@jameskoster
Copy link
Contributor Author

Perhaps it moves to the ellipsis now, then :) It doesn't feel worthy of a main item in the summary panel to me, but happy to hear other opinions about that.

@jasmussen
Copy link
Contributor

The only challenge with the ellipsis is whether that check enables the pingbacks/trackbacks, or whether it surfaces the toggle in the panel, ToolsPanel style. I'd agree on the emphasis, pingbacks is a bit of a vestigial thing, and I'd think it even something you set once in your reading settings and then have a default based on that. Honestly we can even surface the control in the panel based on those same reading settings.

@jameskoster
Copy link
Contributor Author

The tools panel pattern here would be a little convoluted I think. The idea was that selecting the menu item basically worked the same as the current checkbox.

@ntsekouras
Copy link
Contributor

I think we can close this issue now, no?

@jameskoster
Copy link
Contributor Author

There's probably some minor polishing to do, but that can happen in individual issues / PRs 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants