Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media & Text block: Remove Image Size controls from image settings. #49020

Closed
paaljoachim opened this issue Mar 13, 2023 · 3 comments
Closed
Labels
[Block] Image Affects the Image Block [Block] Media & Text Affects the Media & Text Block Needs Design Feedback Needs general design feedback. [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Enhancement A suggestion for improvement.

Comments

@paaljoachim
Copy link
Contributor

paaljoachim commented Mar 13, 2023

What problem does this address?

Currently the Image Size controls are very confusing, as they do not actually change the image but changes the resolution.

Example to where the Image Size controls have been replaced with Image dimensions.
The Image block.
Screenshot 2023-03-13 at 09 38 16

Shows width and height.
As well as percentage.
Changing any of the above will result in a visual difference which can be seen in the backend and frontend.

Example from Media & Text block.

Screenshot 2023-03-13 at 09 13 09

It uses the Image Size drop down controls. Making a change here might not result in any change seen on the backend but the frontend one might see a blurred image if one had selected Thumbnail, medium etc. Even the default Large the image can be blurred on the frontend. I had to tell my client to go to the backend, select the image and in the Image Size drop down change it to Full Size (as I hoped that it would make a difference). The frontend now showed a nice and sharp image.

What is your proposed solution?

To remove Image size controls from the Image settings inside the Media & Text block. There are resize handles directly on the image. One could add in Image dimension controls, but I am not sure if that is needed.

Somewhat related PR:
#48478

@jasmussen @aaronrobertshaw

@paaljoachim paaljoachim added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. [Block] Media & Text Affects the Media & Text Block labels Mar 13, 2023
@jasmussen
Copy link
Contributor

There's a related conversation in #48618 (comment) around standardizing these, but notably improving the verbiage. There seems to be some overlap between 48618 and this.

@Thelmachido Thelmachido added [Block] Image Affects the Image Block [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed labels Mar 14, 2023
@Thelmachido
Copy link

Hi @paaljoachim you might need to further the discussion on the issue @jasmussen mentioned if this is related. I will mark this as a duplicate for now, feel free to add more information if it's necessary to keep this particular issue open.

@Mamaduka
Copy link
Member

I think we can close this issue.

Why?

  • The image block now uses Aspect Ratio + Width/Height controls, which are better tools for the task.
  • The Media & Text (some others) use Resolution controls, this component has better description and context for the users.

Screenshot

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Block] Media & Text Affects the Media & Text Block Needs Design Feedback Needs general design feedback. [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants