Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Editor: URLInput: Remove "required" as a default prop of URLInput #22442

Open
Tracked by #35073
aduth opened this issue May 18, 2020 · 0 comments
Open
Tracked by #35073

Block Editor: URLInput: Remove "required" as a default prop of URLInput #22442

aduth opened this issue May 18, 2020 · 0 comments
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Package] Block editor /packages/block-editor [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@aduth
Copy link
Member

aduth commented May 18, 2020

Previously: #18061 (comment)

Currently, URLInput assigns required attribute to its rendered input. This limits its reusability and makes unnecessary assumptions about its rendering context. It's assumed that this was the default largely based on the assumption of specific contexts in which it was rendered (i.e. RichText link insertion).

Task: Avoid assigning required in URLInput. It should still be supported as an optional (opt-in) prop in cases where it is appropriate. This usage and associated cautions should be sufficiently documented.

@aduth aduth added [Type] Task Issues or PRs that have been broken down into an individual action to take [Package] Block editor /packages/block-editor [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) labels May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Package] Block editor /packages/block-editor [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

No branches or pull requests

1 participant