Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run test suite against WordPress 5.0 build instead of trunk #10412

Closed
danielbachhuber opened this issue Oct 8, 2018 · 6 comments
Closed

Run test suite against WordPress 5.0 build instead of trunk #10412

danielbachhuber opened this issue Oct 8, 2018 · 6 comments
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Enhancement A suggestion for improvement.
Milestone

Comments

@danielbachhuber
Copy link
Member

Now that the core development focus has switched to the 5.0 branch instead of trunk, we should make sure the PHPUnit and e2e test suites run against the 5.0 codebase accordingly.

However, with this being said, we may not be currently running the test suite against trunk. If this is truly the case, then we should get this configured.

Related 9c75e47 0c12b15

@danielbachhuber danielbachhuber added [Type] Enhancement A suggestion for improvement. [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. labels Oct 8, 2018
@danielbachhuber danielbachhuber added this to the WordPress 5.0 milestone Oct 8, 2018
@mtias mtias modified the milestones: WordPress 5.0 RC, WordPress 5.0 Nov 13, 2018
@gziolo
Copy link
Member

gziolo commented Dec 4, 2018

Won't it happen automatically as soon as new Docker images are going to be published? I also think it has to happen after 5.0 is out and the new plugin's version is released which has a minimum version of WordPress set to 5.0. I would personally move it to 5.0.1 Milestone.

@danielbachhuber
Copy link
Member Author

Won't it happen automatically as soon as new Docker images are going to be published? I also think it has to happen after 5.0 is out and the new plugin's version is released which has a minimum version of WordPress set to 5.0.

Well, yes. The idea a couple of months ago was to run the tests against the 5.0 branch so there weren't any surprises upon release.

@gziolo
Copy link
Member

gziolo commented Dec 4, 2018

@youknowriad did that last Friday on WordPress RC branch. This is short summary shared on Slack (https://wordpress.slack.com/archives/C02QB2JS7/p15439257511970):

The different behavior I found:

  • Post formats not supported in Twenty nineteen breaking two tests
  • The custom font sizes of Twenty nineteen breaking one test
  • Core has a different implementation of wp.hooks breaking two tests. (There’s a ticket to align the implementations I think)

All of the tests were green otherwise.
I expect there will be no difference post 5.0 because we’ll probably update the minimum version in the plugins e2e tests and fix all of these.

@youknowriad
Copy link
Contributor

Closing as this is done.

@danielbachhuber
Copy link
Member Author

@youknowriad It's not done though. I've created a new issue #12839

@youknowriad
Copy link
Contributor

So the issue was about running the test suite against 5.0 which is done but yeah if want to run against trunk that's not done, that was never the case actually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants