Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EntitlementProduct should be structured differently #222

Closed
ue71603 opened this issue Aug 5, 2022 · 2 comments
Closed

EntitlementProduct should be structured differently #222

ue71603 opened this issue Aug 5, 2022 · 2 comments
Assignees
@skinkie @Aurige @sgrossberndt @dirkweisser
Labels
enhancement New feature or request to be disussed
Milestone
v2.0

Comments

@ue71603
Copy link
Contributor

ue71603 commented Aug 5, 2022 •
edited by sgrossberndt
Loading

EntitlementProduct probably is underdefined.
Either it should be EntitlementProductRef or better it should be structured like ZonesAlreadyPaid

Containing a

  • FareAuthorityRef and a
  • EntitlementProductRef

What are the other's opinions?
image
@ue71603 ue71603 added enhancement New feature or request to be disussed labels Aug 5, 2022
@ue71603 ue71603 added this to the v2.0 milestone Aug 5, 2022
@ue71603
Copy link
Contributor Author

ue71603 commented Aug 9, 2022

Stefan: From catalog. Not user specific.
Dirk: I have a student card from PTA. DB:StudentCard

EntitlementProduct

  • FareAuthorityRef = OeVCH
  • EntitlementProductRef = 818231
  • EntitlementProductName = Halfprice

Usually selected from a catalog.
Will ask Andreas S., if such a catalogue exist.

Decision: Restructure and document (and we have to see where the catalogue comes from)

@ue71603
Copy link
Contributor Author

ue71603 commented Aug 9, 2022

[09:26] Dohmen, Claus | VDV
There may be additional attributes of a entitlement product necessary to use it in a fare calculation, e.g. validity period

[09:28] Dohmen, Claus | VDV
This could not be covered by a catalogue, because it is am attribute of the individual card rather than of the card type (like e.g. discount level)

@ue71603 ue71603 mentioned this issue Aug 11, 2022
Merged
@ue71603 ue71603 closed this as completed Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinkie skinkie

@Aurige Aurige

@sgrossberndt sgrossberndt

@dirkweisser dirkweisser

Labels
enhancement New feature or request to be disussed
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
5 participants
@skinkie @Aurige @sgrossberndt @dirkweisser @ue71603