Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android] Screen dims & locks while video is playing #744

Closed
tostr7191 opened this issue Aug 16, 2017 · 6 comments
Closed

[android] Screen dims & locks while video is playing #744

tostr7191 opened this issue Aug 16, 2017 · 6 comments

Comments

@tostr7191
Copy link

Hi

On iOS this works correctly, but on android I get this behaviour. After the inactivity timeout the screen goes dim, then black (phone locks). I have found nothing in the docs about this, no settings or something. Is this a bug, or am I just missing something? I have tried it with:

"react-native-video": "^1.0.0",

and

"react-native-video": "^1.2.0",

Same behaviour in both cases.

Best,
tostrio

@tostr7191
Copy link
Author

There is a similiar issue here: #687
No responses though.

@shooterRao
Copy link

shooterRao commented Sep 14, 2017

I have also encountered the same problem..Ios works correctly but android can't work...

@shooterRao
Copy link

@tostrio Hi,I have just solved this problem,use 'react-native-keep-awake', I use it in componentWillMount(){ KeepAwake.activate(); } and componentWillUnmount(){ KeepAwake.deactivate(); },
this problem is solved!

@tostr7191
Copy link
Author

tostr7191 commented Sep 14, 2017

@shooterRao Hi, thanks for the heads up!

We have opted to use react-native-keep-awake as well. But I still think this should be fixed in the video player. Preventing screen timeout seems to be something that the player should include, and not something that should need an external dependency (at least from my point of view). Not to mention that the behaviour is not consistent across platforms.

@shooterRao
Copy link

@tostrio yeah,I agree with you on this point,I also hope this bug can be solved.

@cobarx
Copy link
Contributor

cobarx commented Aug 6, 2018

Fixed by #1117. Will be included in 3.2.0

@cobarx cobarx closed this as completed Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants