Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Authorization header for remote videos #475

Closed
bitfused opened this issue Jan 31, 2017 · 3 comments · Fixed by #805
Closed

Support for Authorization header for remote videos #475

bitfused opened this issue Jan 31, 2017 · 3 comments · Fixed by #805

Comments

@bitfused
Copy link

Would be great if we could add http header support for remote videos similarly to what has been done with Image component: https://github.com/facebook/react-native/pull/7338/files
@ghost
Copy link

ghost commented Feb 9, 2017

Seems like a slippery slope IMHO, and something which should be handled by a proxy or by RN internals. Otherwise we'd be duping code in RN core.

@duhseekoh
Copy link
Contributor

Why a slippery slope? Blanket support for throwing headers on the video requests seems like a one and done type solution.

@ghost
Copy link

ghost commented Jun 15, 2017

I suppose it doesn't really matter this is react native. Where dogs play a serious poker game at least once a week. Please ignore my comment.

@emrahdk emrahdk mentioned this issue Oct 2, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added optional request headers for remote assests (android & ios) emrahdk/react-native-video
2 participants
@duhseekoh @bitfused