Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Back" action when closing keyboard not working #276

Closed
TBog opened this issue Apr 3, 2022 · 15 comments
Closed

"Back" action when closing keyboard not working #276

TBog opened this issue Apr 3, 2022 · 15 comments

Comments

@TBog
Copy link
Owner

TBog commented Apr 3, 2022

I don't think this is fixed properly:

  • Enable "Back" action when closing keyboard" on a Samsung S5, Android 10: the keyboard is closes with the Back button, but it does NOT trigger the "Back" action.
  • Disable "Back" action when closing keyboard" on a Nokia 3, Android 9: the keyboard doesn't even close, i.e. the Back button is blocked completely. (Enabling the option does trigger the "Back" action on this device.)

Originally posted by @ltguillaume in #238 (comment)

@TBog
Copy link
Owner Author

TBog commented Apr 13, 2022

I hope this will be fixed by PR #275

@TBog
Copy link
Owner Author

TBog commented Apr 18, 2022

@ltguillaume can you check if it's fixed on v6.12

@ltguillaume
Copy link
Contributor

Just checked the first point on S5: still the same issue with 6.12... Will check the second point ASAP.

@TBog
Copy link
Owner Author

TBog commented Apr 19, 2022

Then maybe commit 345f2fa will fix it.

@TBog
Copy link
Owner Author

TBog commented Apr 19, 2022

please try v6.12-dev.1

@ltguillaume
Copy link
Contributor

ltguillaume commented Apr 19, 2022

Yes, this fixed it! Thank you 😁

@TBog TBog closed this as completed Apr 20, 2022
@ltguillaume
Copy link
Contributor

Oops! This introduces a new problem! When scrolling down through the list, the keyboard is hidden, but then the Back action is immediately called as well (which in my case triggers the widget mode). So, I can't scroll through the result list anymore...

@TBog
Copy link
Owner Author

TBog commented Apr 21, 2022

When scrolling down through the list, the keyboard is hidden, but then the Back action is immediately called as well

fixed with commit 489924a
I just hope I didn't introduce any other unintended features (bugs) with this commit 😁

@ltguillaume
Copy link
Contributor

Haha, we'll get there 😋

@ltguillaume
Copy link
Contributor

I'm not sure if that commit will also tackle the following:

  1. When trying to change the icon via the context menu, the dialog immediately closes after opening, because the keyboard is closed first, which triggers the Back action.
  2. When trying to pick an icon from an icon pack and pressing Enter after I typed the search term, the keyboard closes, but this also closes the entire icon picker dialog (i.e. the Back action is triggered).

@TBog
Copy link
Owner Author

TBog commented Apr 22, 2022

Thanks for reporting, I'll check it and see if I can make a new dev release

@ltguillaume
Copy link
Contributor

I'm not sure if that commit will also tackle the following:

1. When trying to change the icon via the context menu, the dialog immediately closes after opening, because the keyboard is closed first, which triggers the Back action.

2. When trying to pick an icon from an icon pack and pressing Enter after I typed the search term, the keyboard closes, but this also closes the entire icon picker dialog (i.e. the Back action is triggered).

FYI, both (1) and (2) are still present in 6.14.

@TBog
Copy link
Owner Author

TBog commented Apr 27, 2022

Thank for pointing it out, I'll try to reproduce the issue on the emulator.
I understand why it would happen, just need to find a good way to fix it.

@ltguillaume
Copy link
Contributor

These two issues have been resolved in the 6.14dev1 release, thanks!

@ltguillaume
Copy link
Contributor

In 6.15, "Back" action when closing keyboard stops working completely after a while. It's hard to reproduce, but it's there nonetheless. Once it's starts happening, it doesn't matter if I flick the option off and then on again, I have to close the launcher in order for it to start working again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants