Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Websockets don't work in firefox #706

Closed
Zeroto opened this issue Jul 28, 2018 · 2 comments
Closed

Websockets don't work in firefox #706

Zeroto opened this issue Jul 28, 2018 · 2 comments
Labels
bug-major

Comments

@Zeroto
Copy link

Zeroto commented Jul 28, 2018

Description

It seems that firefox includes keep-alive in the connection header causing Suave to send back a bad request during the websocket handshake

Current behaviour:

Suave sends back a 400 bad request because it requires the connection header to be just Upgrade

Desired behaviour:

Suave ignores the other values in the connection header and processes the connection upgrade

Workaround

manually strip the other values from the connection header before sending the request to the handshake.
@ademar ademar closed this as completed in 7b49ffa Jul 31, 2018
@ademar
Copy link
Member

ademar commented Jul 31, 2018

Hi @Zeroto I've pushed a new pre-release v2.5.0-beta2 with a fix. Please give it a try. Thanks.

@Zeroto
Copy link
Author

Zeroto commented Aug 3, 2018

Works ok now. Thanks 😄

@Zaid-Ajaj Zaid-Ajaj mentioned this issue Oct 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug-major
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ademar @Zeroto