Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Symfony FatalError in the declaration of bindValue() #4237

Closed
1 task done
damms005 opened this issue Nov 10, 2024 · 1 comment
Closed
1 task done

[Bug]: Symfony FatalError in the declaration of bindValue() #4237

damms005 opened this issue Nov 10, 2024 · 1 comment
Labels

Comments

@damms005
Copy link

Is the bug applicable and reproducable to the latest version of the package and hasn't it been reported before?

  • Yes, it's still reproducable

What version of Laravel Excel are you using?

3.1.59

What version of Laravel are you using?

latest

What version of PHP are you using?

8.3.11

Describe your issue

When generating helpers using php artisan ide-helper:generate --helpers command, I get error:

Symfony\Component\ErrorHandler\Error\FatalError

Declaration of Maatwebsite\Excel\DefaultValueBinder::bindValue(PhpOffice\PhpSpreadsheet\Cell\Cell $cell, $value) must be compatible with PhpOffice\PhpSpreadsheet\Cell\DefaultValueBinder::bindValue(PhpOffice\PhpSpreadsheet\Cell\Cell $cell, mixed $value): bool

How can the issue be reproduced?

Run any code that causes the DefaultValueBinder's bindValue() method to be called, or in my case run the php artisan ide-helper:generate --helpers command from Barry's IDE helper package

What should be the expected behaviour?

The signature of the bindValue() must be compatible with PhpOffice's

@damms005 damms005 added the bug label Nov 10, 2024
@patrickbrouwers
Copy link
Member

#4234 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants