Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appointments form does not react on blocked timeslot in either Destination calender or the 'control for conflicts calendar #546

Open
nicoletflr opened this issue Oct 1, 2024 · 11 comments

Comments

@nicoletflr
Copy link

Steps to reproduce

  1. Go to appointment page in Appointment app
    2.Define Destination calendar
  2. Define 'Control for conflicts' calendar
  3. add an appointment in 'control for conflicts' calendar
  4. Go to form as a user and fill in form.
  5. Select day of the appointment from step 4, see if the timeslot is blocked
  6. Timeslot is still available!
  7. add an appointment in Destination calendar
  8. Go to form as a user and fill in form.
  9. Select day of the appointment from step 8, see if the timeslot is blocked
  10. Time slot is still available!

Expected behavior
When a timeslot is filled in with an appointment either in the Destination calendar or the Control for conflicts calendar, than the timeslot should not be available in the form.

Actual behaviour
When a timeslot is filled in with an appointment either in the Destination calendar or the Control for conflicts calendar, than the timeslot is still available in the form

Appointments app version: 2.18
calendars used: Nextcloud calendar 4.7.16
Nextcloud version 27.1.10 enterprise

@SergeyMosin
Copy link
Owner

In steps 3 and 7 are you adding a full-day event or a regular event like a 1 hour long for example ?
If it is a full-day event, the Full day can block option must be selected in the settings

@nicoletflr
Copy link
Author

Thanks Sergey for your reply. I tried various lengths of events: half an hour, an hour, 8 hours, but not full-day

@SergeyMosin
Copy link
Owner

I still can not replicate this.

vokoscreenNG-2024-10-01_12-10-14.webm

@nicoletflr
Copy link
Author

nicoletflr commented Oct 2, 2024

I just checked again and it appeared today that 02-10-2024 the appointments up to 23-10 are all correctly blocked. But from 24-10 onwards it is not. I'm not shure this was already the situation when I reported the problem, because it started with a new appointment at 24-10 where it should have been blocked. Today I checked day by day in my agenda and the next 3 weeks are okay but after that the problem appears.

@SergeyMosin
Copy link
Owner

Is there "Day light saving" time-shift in your country on Oct 23 this year by any chance ?

@nicoletflr
Copy link
Author

nicoletflr commented Oct 2, 2024

No, that time-shift is at 27 oktober this year. And I have the payed version of your app with more weeks to plan.

@nicoletflr
Copy link
Author

I checked at 3 okt and still until 23-10 all is well, but 24-10 and onwards time slots are not blocked. I would greatly appreciate it if you can help me with this bug.

@SergeyMosin
Copy link
Owner

@nicoletflr Can you send me ( sergey at srgdev.com ) one of the events that is NOT blocking, so I can try to replicate it on my machine. Also, are there any Appointments related errors in the logs ?

@nicoletflr
Copy link
Author

the blocking seems to be date based, not event based, so I'm not sure if this will help. I will check with my hosting provider for the logs and will come back to you!

@SergeyMosin
Copy link
Owner

the blocking seems to be date based, not event based, so I'm not sure if this will help

In order to block, the app needs to extract the dates form conflicting events. There are some rare events that can not be properly parsed. I just want to make sure that this not the case.

@SergeyMosin
Copy link
Owner

I still can not replicate this issue. Can you send me the settings dump for the page, it can be found in the Settings > Advanced > Debugging > Settings Dump

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants