Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] include global footer in npm package #429

Closed
bennypowers opened this issue Jul 13, 2022 · 1 comment · Fixed by #438
Closed

[bug] include global footer in npm package #429

bennypowers opened this issue Jul 13, 2022 · 1 comment · Fixed by #438
Assignees
@bennypowers
Labels
bug Something isn't working

Comments

@bennypowers
Copy link
Member

We neglected to include rh-global-footer.js in the latest release.

Originally posted by @bennypowers in #420 (reply in thread)
@bennypowers
Copy link
Member Author

Turns out this is more difficult than originally anticipated, since esbuild doesn't yet support multiple entry points while preserving module structure but also bundling css into javascript modules like we do.

We can investigate switching to rollup for slower but more correct dist bundles, while we wait for esbuild to develop the necessary options and apis.

@bennypowers bennypowers self-assigned this Jul 13, 2022
@bennypowers bennypowers mentioned this issue Jul 20, 2022
Merged
@bennypowers bennypowers added the bug Something isn't working label Jul 20, 2022
@bennypowers bennypowers moved this from Backlog to Review in Red Hat Design System Jul 20, 2022
Repository owner moved this from Review to Done in Red Hat Design System Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bennypowers bennypowers

Labels
bug Something isn't working
Projects
Red Hat Design System
Status: Done ☑️
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: build with typescript RedHat-UX/red-hat-design-system
1 participant
@bennypowers