Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add getgradlogpartition Exponential #152

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

HoangMHNguyen
Copy link
Contributor

Add getgradlogpartition function to Exponential distribution

@HoangMHNguyen HoangMHNguyen self-assigned this Dec 15, 2023
@HoangMHNguyen HoangMHNguyen marked this pull request as ready for review December 15, 2023 13:55
@Nimrais
Copy link
Member

Nimrais commented Dec 15, 2023

@HoangMHNguyen thanks a lot!

Only one little comment, even in the one dimensional case we are considering natural parameters as a one dimensional vector not a scalar.

Can you address this issue in your other distributions? I fixed it here to make the point.

@Nimrais Nimrais merged commit decb514 into implement-grad-logpartition Dec 15, 2023
1 check failed
@Nimrais Nimrais deleted the gradlogpartition_exponential branch December 15, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants