bug(YouTube - Hide layout components): 'Hide gray separator' does not do anything

[LisoUseInAIKyrios]

Bug description

Hide gray separator seems obsolete and the setting no longer seems to do anything

When spoofing to an old version the separators can show in the library and a few other places, but the hide setting does not seem to hide anything there either.

The code for this is:

        final var graySeparator = new StringFilterGroup(
                Settings.HIDE_GRAY_SEPARATOR,
                "cell_divider" // layout residue (gray line above the buttoned ad),
        );

The component cell_divider does appear in the litho logs, but it now appears to be blank space or some other non visible element because there is no visual change when this is hidden or not.

 
 
Is this setting still relevant? Should it be removed?

If this still shows up, then the setting description should be updated to describe exactly where.

Acknowledgements

• I have checked all open and closed bug reports and this is not a duplicate.
• I have chosen an appropriate title.
• All requested information has been provided properly.

[kazimmt]

It still removes some empty spaces Between Title 1 & Thumbnail 2

[LisoUseInAIKyrios]

So it's just empty space.

Hiding it may not make sense anymore.

[oSumAtrIX]

Have you checked light mode for the separator?

[LisoUseInAIKyrios]

I don't see any changes in either mode.

[kazimmt]

I've checked in light mode also (Tho my one is monet)
Need to re-check
I guess they changed the color but still Seperator presents. Maybe not gray

[kazimmt]

Even on stock android, it's just empty space 😧

[0xrxL]

19.43.34 - Dark Mode

cell_divider is still here

[oSumAtrIX]

That's negligible. The divider was particularly ugly in the feed. It can be removed

[0xrxL]

That's negligible. The divider was particularly ugly in the feed. It can be removed

In fact I just unlocked it in My Tab (the unique view where it's visible...at this point).

[oSumAtrIX]

I don't know what a My Tab is. It's not relevant if it's used in such hidden places

[LisoUseInAIKyrios]

Setting was removed with c1fad76

If anyone wants to still hide those two grey separators in the library then use the custom filter:
^cell_divider

[ILoveOpenSourceApplications]

I saw it in two more areas in search. Just wanted to point that.

One on top of channel profiles.

Second on top of the search result categories.

[kazimmt]

The one in search result is also different
These are official cards i guess

[kazimmt]

@LisoUseInAIKyrios Going to revert the commit or not?

[LisoUseInAIKyrios]

I don't see how the hide function is still relevant anymore. At least, not relevant enough to have a dedicated setting when a custom filter works for these odd ball situations.

[ILoveOpenSourceApplications]

While custom filters can be powerful, the Hide gray separators setting offers a simple solution for users who want a cleaner interface. Even if its use cases are limited, it's a convenient option for those who prefer a minimalist look. Plus, we can never be sure what future YouTube might do (#spooky).

[LisoUseInAIKyrios]

If YouTube starts using it again then the setting can be added back. But right now it's too negligible to have a dedicated setting to make a change that few will ever notice. Keeping the settings concise and meaningful is a perk itself.

[oSumAtrIX]

Also you can use custom filters.