You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Okay, I just looked at the discussions of the standard, and it actually allows the comma separator (which is surprising).
My concern is data that potentially mixes separators, because even preferring , for decimal, software will likely output . for ISO timestamps (data.table itself is an example):
P.S. Datetimes are weird. Were you aware that ISO 8601 allows fractional values other than seconds? E.g. 10:20,5 is valid and means 10:20:30... Probably not a good idea to support this though. Something more sane like RFC 3339 draft (which fwrite seems to follow) is already supported and that's likely good enough.
My concern is data that potentially mixes separators, because even preferring
,
for decimal, software will likely output.
for ISO timestamps (data.table
itself is an example):So this fix (which, if I understand correctly, is trying to reparse with the other separator if one fails) should be OK?
Here's a sample of my real data that tripped this issue, which was output by data.table's
fwrite()
:P.S. Datetimes are weird. Were you aware that ISO 8601 allows fractional values other than seconds? E.g.
10:20,5
is valid and means10:20:30
... Probably not a good idea to support this though. Something more sane like RFC 3339 draft (whichfwrite
seems to follow) is already supported and that's likely good enough.Originally posted by @kav2k in #6445 (comment)
The text was updated successfully, but these errors were encountered: