-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Change LightningLoggerBase
to Logger
#973
🐛 Change LightningLoggerBase
to Logger
#973
Conversation
Is there a workaround at the moment by installing an older version? |
If we want to maintain compatibility to older versions, then we could do something like this: try:
from pytorch_lightning.loggers import Logger
except ImportError:
from pytorch_lightning.loggers import LightningLoggerBase
Logger = LightningLoggerBase |
@senarvi I did commit your idea to maintain older version compatibility |
Any updates on this? Having to change |
Are we able to get this merged? I'm willing to help out any way possible. It seems like not being able to use lightning bolts with the latest pytorch lightning seems like a big deal |
LightningLoggerBase
to Logger
What does this PR do?
Fix
cannot import name 'LightningLoggerBase' from 'pytorch_lightning.loggers'
. Sincepytorch_lightning.loggers.base.LightningLoggerBase
is deprecated overpytorch_lightning.loggers.base.Logger
.Fixes #972
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.