Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer): display correct z-value position in tip posit… #17005

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Dec 2, 2024

…ion field

closes RQA-3723

Overview

The tip position field didn't correctly display the default z-value if it is something other than 0 (which is always should be? lol)

Test Plan and Hands on Testing

make a protocol with a tube rack and create a transfer. See that the default tip position shows 1 for the z value. There should also be a warning banner that appears by default for a tube rack.

test changing the values and it should be reflected correctly in the field

Changelog

  • use the zValue which gets the default value if the default was unchanged

Risk assessment

low

@jerader jerader requested a review from a team as a code owner December 2, 2024 17:06
@jerader jerader requested review from koji and ncdiehl11 December 2, 2024 17:06
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jerader jerader merged commit 36c3208 into edge Dec 2, 2024
18 checks passed
@jerader jerader deleted the pd_fix-position-values branch December 2, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants