Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): update motor position before homing #16887

Conversation

TamarZanzouri
Copy link
Contributor

@TamarZanzouri TamarZanzouri commented Nov 19, 2024

Overview

fix for part of https://opentrons.atlassian.net/browse/RQA-3576.

Test Plan and Hands on Testing

move the gantry before homing and then home the whole gantry.
then move the gantry again and home again.

Changelog

update motor status in _update_position_estimation

Risk assessment

low?

@TamarZanzouri TamarZanzouri requested a review from a team as a code owner November 19, 2024 17:05
@sfoster1 sfoster1 changed the title api(fix): update motor position before homing fix(api): update motor position before homing Nov 19, 2024
@TamarZanzouri
Copy link
Contributor Author

TamarZanzouri commented Nov 19, 2024

tested and works as expected @sfoster1

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@TamarZanzouri TamarZanzouri merged commit 0dacfb3 into edge Nov 20, 2024
21 checks passed
@TamarZanzouri TamarZanzouri deleted the RQA-3576-bug-flex-protocol-did-not-populate-stall-collision-error-upon-crash-2-x branch November 20, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants