Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VORBIS-VENDOR on flac & opus, info.ISFT on wav Custom Properties are unremovable, The same behavior aren't present on mp3 and m4a #385

Closed
kissthermite opened this issue Oct 23, 2023 · 13 comments · Fixed by #393
Labels
bug Something isn't working
Milestone

Comments

@kissthermite
Copy link

1

2

3


1

2

3

@nlogozzo
Copy link
Member

I believe these fields are required parts of the file's tag header and shouldn't really be considered "custom properties". I will find out...

@nlogozzo
Copy link
Member

Zeugma440/atldotnet#236

@nlogozzo nlogozzo added the bug Something isn't working label Oct 23, 2023
@nlogozzo nlogozzo added this to the V2023.10.0 milestone Oct 23, 2023
@kissthermite
Copy link
Author

Wait. The proposed solution is to remove VORBIS VENDOR? how about moving it to File Properties instead?

@nlogozzo
Copy link
Member

The proposed solution is to remove VORBIS VENDOR?

No the proposal is to hide VORBIS VENDOR from being shown as a "Custom Property" since it's supposed to be an encoded field of the codec used when the file is created. It isn't meant to be altered/deleted.

@nlogozzo
Copy link
Member

how about moving it to File Properties instead?

We could do this, but the fact is it shouldn't be considered a Custom Property as I said before it's not to be edited/altered.

Showing it under File Properties is kind of useless too since it's more for music players to learn the codec of the file and not something concerning the tag.

@kissthermite
Copy link
Author

kissthermite commented Oct 24, 2023

Showing it under File Properties is kind of useless too since it's more for music players to learn the codec of the file and not something concerning the tag.

it's kinda useful for determining the origin of the file.

name

like this file right here. And pretty much all of my flac which i got from soulseek and deezer have identical VORBIS-VENDOR while the previous flac from this issue
have unique VORBIS VENDOR which i guess it's because FFmpeg doing it's thing inside yt-dlp.

@fsobolev
Copy link
Member

How about renaming "File properties" to "Read-only properties" and showing VORBIS-VENDOR and other things there if they are present in a file?

@kissthermite
Copy link
Author

kissthermite commented Oct 24, 2023

which i guess it's because FFmpeg doing it's thing inside yt-dlp.

Forgot to mention but all five files on this issue screenshot are obtained from YouTube Music via Parabolic

@nlogozzo
Copy link
Member

nlogozzo commented Oct 24, 2023

How about renaming "File properties" to "Read-only properties" and showing VORBIS-VENDOR and other things there if they are present in a file?

I'll talk to ATL developer about having read only additional properties

@nlogozzo nlogozzo removed this from the V2023.10.0 milestone Oct 26, 2023
@nlogozzo
Copy link
Member

nlogozzo commented Nov 2, 2023

@kissthermite Hi! Could you do me a favor and email me one of the wav files containing info.ISFT that isn't getting removed. My email is [email protected] . Thanks!

@kissthermite
Copy link
Author

@nlogozzo Sure. Just did it few moments ago.

@nlogozzo nlogozzo added this to the V2023.11.1 milestone Nov 3, 2023
@nlogozzo
Copy link
Member

nlogozzo commented Nov 4, 2023

Turns out these fields are removable but there were independent bugs affecting wav and vorbis files that prevented them from being removed.

The developer of the tag library we use fixed these issues so I will update Tagger today with the fixes :)

@nlogozzo
Copy link
Member

nlogozzo commented Nov 5, 2023

https://github.com/NickvisionApps/Tagger/releases/tag/2023.11.1

Will be available through flathub within the hour!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants