Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed url to Lee2019 #621

Merged
merged 3 commits into from
Jun 9, 2024
Merged

Fixed url to Lee2019 #621

merged 3 commits into from
Jun 9, 2024

Conversation

toncho11
Copy link
Contributor

@toncho11 toncho11 commented Jun 7, 2024

Closes #616

@bruAristimunha
Copy link
Collaborator

@toncho11
Copy link
Contributor Author

toncho11 commented Jun 8, 2024

Can you solve Cho dataset too @toncho11?

https://github.com/NeuroTechX/moabb/blob/develop/moabb%2Fdatasets%2Fgigadb.py#L16

What is the problem with Cho 2017? Are you unable to download it?

@bruAristimunha
Copy link
Collaborator

Same problem I think, they were hosted in the same place

@toncho11
Copy link
Contributor Author

toncho11 commented Jun 8, 2024

Same problem I think, they were hosted in the same place

You mean you did not test. Cho 2017 is actually on https even if the name of the server starts with "ftp":
GIGA_URL = "https://ftp.cngb.org/pub/gigadb/pub/10.5524/100001_101000/100295/mat_data/"

I did a quick test and I do not think that there is a problem with Cho 2017.
Please test as well to confirm that there is no problem.

But if they are also hosted on the same server as Lee, the url should be:

https://s3.ap-northeast-1.wasabisys.com/gigadb-datasets/live/pub/10.5524/100001_101000/100295/mat_data/

@sylvchev
Copy link
Member

sylvchev commented Jun 9, 2024

I'll check this

@sylvchev sylvchev merged commit 2ee6cdd into NeuroTechX:develop Jun 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lee and Cho dataset are not using anymore FTP
3 participants