-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hinss2021 dataset #580
Add Hinss2021 dataset #580
Conversation
@@ -0,0 +1,169 @@ | |||
""" | |||
This example uses the Hinss2021 dataset. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm feeling like this tutorial has a little more content than usual, which is great! However, I think we can adjust the level of explaining to be a little more self-contained:
Overall, I think just adding one note with a basic concept or idea core of the tutorial would be enough. And more comments throughout the whole tutorial.
Some examples:
https://neurotechx.github.io/moabb/auto_examples/plot_benchmark_braindecode.html
With more content:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @gcattan and @jiggychauhi
Thank you very much for your PR, I did a first review.
One thing that I noticed is that the changes in the dataset summary are missing, and I think the doc details of the classes are wrong, can you regenerate the doc and take a look?
Co-authored-by: Bru <[email protected]>
Co-authored-by: Bru <[email protected]>
Co-authored-by: Bru <[email protected]>
complete missing doc on paradigms.rst
…into feat/neuroergo2021 # Conflicts: # examples/plot_Hinss2021_classification.py
All good @gcattan! When everything is green, we can apply the merge; I just corrected some details of the documentation formation that were wrong. I usually use this site to generate these .rst tables https://tableconvert.com/restructuredtext-generator Thank you for your contribution! |
Ok, thanks @bruAristimunha |
This PR adds the dataset from Neuroergonomic 2021 (https://zenodo.org/records/5055046).