Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hinss2021 dataset #580

Merged
merged 22 commits into from
May 9, 2024
Merged

Conversation

gcattan
Copy link
Contributor

@gcattan gcattan commented Apr 28, 2024

This PR adds the dataset from Neuroergonomic 2021 (https://zenodo.org/records/5055046).

@gcattan gcattan marked this pull request as ready for review April 28, 2024 13:46
examples/plot_Hinss2021_classification.py Outdated Show resolved Hide resolved
examples/plot_Hinss2021_classification.py Outdated Show resolved Hide resolved
examples/plot_Hinss2021_classification.py Outdated Show resolved Hide resolved
examples/plot_Hinss2021_classification.py Outdated Show resolved Hide resolved
@@ -0,0 +1,169 @@
"""
This example uses the Hinss2021 dataset.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

examples/plot_Hinss2021_classification.py Outdated Show resolved Hide resolved
examples/plot_Hinss2021_classification.py Show resolved Hide resolved
moabb/datasets/Hinss2021.py Outdated Show resolved Hide resolved
moabb/datasets/Hinss2021.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@bruAristimunha bruAristimunha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gcattan and @jiggychauhi

Thank you very much for your PR, I did a first review.

One thing that I noticed is that the changes in the dataset summary are missing, and I think the doc details of the classes are wrong, can you regenerate the doc and take a look?

@gcattan gcattan requested a review from bruAristimunha May 7, 2024 08:27
@bruAristimunha bruAristimunha enabled auto-merge (squash) May 9, 2024 11:34
@bruAristimunha
Copy link
Collaborator

All good @gcattan!

When everything is green, we can apply the merge; I just corrected some details of the documentation formation that were wrong. I usually use this site to generate these .rst tables https://tableconvert.com/restructuredtext-generator

Thank you for your contribution!

@gcattan
Copy link
Contributor Author

gcattan commented May 9, 2024

Ok, thanks @bruAristimunha

@bruAristimunha bruAristimunha merged commit 8649a86 into NeuroTechX:develop May 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants