Add match_all method in paradigm to support CompoundDataset evaluation with MNE epochs
#473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # moabb/datasets/fake.py
moabb/paradigms/base.py
Outdated
Comment on lines
424
to
431
| def match_all(self, datasets: List[BaseDataset]): | ||
| """ | ||
| Initialize this paradigm to match all datasets in parameter: | ||
| - `self.resample` is set to match the minimum frequency in all datasets, minus 0.5. | ||
| If the frequency is 128 for example, then MNE can returns 128 or 129 samples | ||
| depending on the dataset, even if the length of the epochs is 1s | ||
| The `-0.5` solves this particular issue. | ||
| - `self.channels` is initialized with the channels which are common to all datasets. |
There was a problem hiding this comment.
Can you make the -0.5 Hz a default parameter?
|
Can you please alter the what's new file? @gcattan |
|
Thank you @gcattan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CompoundDataset supports the merging of datasets with different sampling frequencies and channels.
When Epochs are used for evaluation, MNE failed to merge epochs with different frequencies and channels.
This PR introduces the
match_allmethod in theBaseParadigm. It initialized theresampleandchannelsmembers of a paradigm to be compatible with the sampling frequency and channels of all datasets passed as parameters.@bruAristimunha FYI