-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add c-VEP paradigm and first dataset #463
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @thijor and @PierreGtch!
The code is very good! I was reviewing, and I posted my main comment in the review. It would be lovely to try to create some function in the thielen2021, especially in the part get_single_subject_data, to allow and to facilitate the integration of new CVEP datasets :)
I will fix the pytest issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am happy :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me too :D
Thank you @PierreGtch and @thijor =) |
Online @thijor and @PierreGtch To use, please install from the github until next release: https://neurotechx.github.io/moabb/install/install_source.html#installing-moabb-from-the-source |
Closes #366