-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saving the model #401
Merged
carraraig
merged 38 commits into
NeuroTechX:develop
from
bruAristimunha:saving_the_model
Jun 22, 2023
Merged
Saving the model #401
carraraig
merged 38 commits into
NeuroTechX:develop
from
bruAristimunha:saving_the_model
Jun 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # docs/source/README.md
It will fail in the tests |
bruAristimunha
commented
Jun 19, 2023
carraraig
reviewed
Jun 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to be merged
TO-DO Bruno: |
Feel free to apply the merge when everything turns green @carraraig! |
Thanks @bruAristimunha ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request we did a lot of things. Added save option for pytorch, keras and traditional pipeline. We fixed an issue with parallelization that is not using thread behavior, and was causing complications when running on some computers.
The new save is consistent and has testing for new code coverage.