Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyvo.io.vosi.vodataservice.Table.describe() fails for description None #5

Closed
trjaffe opened this issue Nov 21, 2019 · 3 comments
Closed

Comments

@trjaffe
Copy link
Contributor

trjaffe commented Nov 21, 2019

If the metadata for the table description is empty in a registry query result, then if you call the describe() method, it doesn't exit gracefully:

heasarc_tap_services=vo.regsearch(servicetype='tap',keywords=['heasarc'])
heasarc_tables=heasarc_tap_services[0].service.tables
print(type(heasarc_tables['abellzcat']))
<class 'pyvo.io.vosi.vodataservice.Table'>
heasarc_tables['abellzcat'].describe()

leads not to printing of None or something but an exception on a AttributeError.

@trjaffe
Copy link
Contributor Author

trjaffe commented Nov 21, 2019

And the related question, why do all of the ones I check have None for the description? Is PyVO getting the wrong thing?

@trjaffe
Copy link
Contributor Author

trjaffe commented Dec 4, 2019

Think we should bump up the priority on this, specifically the second question, why no descriptions are appearing at all. Everything starts with looking for the tables you want, so the description is important.

@stargaser
Copy link
Contributor

The fix in pyvo has been merged. HEASARC has fixed all its descriptions so that they are all populated. IRSA still needs to fix the descriptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants