Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separate container for libvirt #382

Closed
ivan4th opened this issue Aug 9, 2017 · 0 comments · Fixed by #393
Closed

Use separate container for libvirt #382

ivan4th opened this issue Aug 9, 2017 · 0 comments · Fixed by #393

Comments

@ivan4th
Copy link
Contributor

ivan4th commented Aug 9, 2017

From https://github.com/Mirantis/virtlet/blob/master/docs/design-proposals/vm-isolation.md#additional-security-measures

Use separate container for libvirt. This entails changing how we prepare the tap fd in vmwrapper because mounting network namespace directory can be problematic in some cases (e.g. because of one of /run or /var/run being a symbolic link). Basically tap fd must be prepared on Virtlet side and then sent over a Unix domain socket to vmwrapper process (the socket may reside on an emptyDir volume). With current version of Go this is somewhat complicated because the problem with switching namespaces inside Go process, so this will mean starting a subprocess that will prepare and send the file descriptor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant