This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Fix process cancelation #3131
Merged
Fix process cancelation #3131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Processes were not being killed due to the path to the external scripts being incorrect. Fix this by relying on the tree-kill package rather than shelling out to an external script to kill a process and its children. Also add sinon as a dev dependency for testing purposes. Updates #3044
|
That sounds good. Feel free to close this pr. |
ramya-rao-a
reviewed
Mar 27, 2020
src/debugAdapter/goDebug.ts
Outdated
| @@ -36,6 +36,7 @@ import { | |||
| getInferredGopath, | |||
| parseEnvFile | |||
| } from '../goPath'; | |||
| import { killTree } from '../util'; | |||
There was a problem hiding this comment.
We cannot have the debug adapter take a dependency on util which depends on the vscode module. This is because the debug adapter is run in a process different from the rest of the extension. The process in which the rest of the extension runs has access to vscode, but the process running the debug adapter doesnt. That's why previously, the kill code is copied here in this file instead of re-using from util
There was a problem hiding this comment.
We can however move the killTree out of the util into a separate file and then re-use it from there
We cannot take a dependency on util, which depends on the vscode module because the debug adapter runs in a process that doesn't have access to the vscode module.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Processes were not being killed due to the path to the external scripts being incorrect. Fix this by relying on the tree-kill package rather than shelling out to an external script to kill a process and its children.
Also add sinon as a dev dependency for testing purposes.
Updates #3044