Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Fix #2551 : Code coverage disappears when typing a character #2853

Merged
merged 6 commits into from
Apr 20, 2020

Conversation

kegsay
Copy link
Contributor

@kegsay kegsay commented Oct 22, 2019

This also preserves an earlier fix to keep coverage when the modifications
are only due to comment edits.

Supersedes #2586

This also preserves an earlier fix to keep coverage when the modifications
are only due to comment edits.

Supersedes microsoft#2586
@msftclas
Copy link

msftclas commented Oct 22, 2019

CLA assistant check
All CLA requirements met.

@kegsay
Copy link
Contributor Author

kegsay commented Oct 22, 2019

The failing test is:

1) Test SignatureHelp Provider using gogetdoc

only on Go 1.12 on Mac which appears unrelated to these changes.

Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kegsay, apologies for the delay in responding.

I pushed a few commits to fix merge conflicts and some new format and linting rules

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants