Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove the recent yarn engine requirement #71

Merged
merged 1 commit into from
Jul 19, 2019

Conversation

dbjorge
Copy link
Contributor

@dbjorge dbjorge commented Jul 19, 2019

Description of changes

Previously, we set an engine requirement of "yarn": "^1.15.1", which forced prospective consumers to use pretty recent yarn versions in their consuming projects even though we don't actually need any recent yarn features. We aren't doing anything special in our package.json; we don't need to require any single specific package manager (npm, yarn, etc are fine to consume the project with), so this just removes the package manager engine requirement outright.

Pull request checklist

  • PR title respects Conventional Commits (starts with fix:, feat:, etc, and is suitable for user-facing release notes)
  • PR contains no breaking changes, OR description of both PR and final merge commit starts with BREAKING CHANGE:
  • (if applicable) Addresses issue: This package requires yarn >1.15.1, seems really aggressive #70
  • [n/a] Added relevant unit tests for your changes
  • Ran yarn precheckin
  • [n/a] Verified code coverage for the changes made

@dbjorge dbjorge requested a review from a team July 19, 2019 18:00
@dbjorge dbjorge merged commit f73ea49 into microsoft:master Jul 19, 2019
@dbjorge dbjorge deleted the remove-yarn-engine-requirement branch July 19, 2019 18:02
dbjorge added a commit that referenced this pull request Jul 19, 2019
Bumps all devDependencies up to latest versions. Leaving bumps of non-dev-dependencies @types/sarif and axe-core for a separate PR since they'll require test updates to check for input format changes.

(This should be a chore: and not a fix:, but I used the wrong tag in the last fix: PR's merge commit [the GitHub behavior where it doesn't use the PR title for the merge commit title if there's only one commit in the PR strikes again], so using fix here to artifically force a semantic-release that includes #71 )
@ada-cat
Copy link
Collaborator

ada-cat commented Jul 19, 2019

🎉 This PR is included in version 2.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants