Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add TreatmentCol Type check at the very beginning #1816

Merged
merged 6 commits into from
Jan 31, 2023

Conversation

dylanw-oss
Copy link
Contributor

What changes are proposed in this pull request?

If customer's dataset Treatment column is boolean type, it will throw exception now due to residual computation can't be performed on boolean data type. This change is to convert it to integer type internally.

@github-actions
Copy link

Hey @dylanw-oss 👋!
Thank you so much for contributing to our repository 🙌.
Someone from SynapseML Team will be reviewing this pull request soon.

We use semantic commit messages to streamline the release process.
Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix.
This helps us to create release messages and credit you for your hard work!

Examples of commit messages with semantic prefixes:

  • fix: Fix LightGBM crashes with empty partitions
  • feat: Make HTTP on Spark back-offs configurable
  • docs: Update Spark Serving usage
  • build: Add codecov support
  • perf: improve LightGBM memory usage
  • refactor: make python code generation rely on classes
  • style: Remove nulls from CNTKModel
  • test: Add test coverage for CNTKModel

To test your commit locally, please follow our guild on building from source.
Check out the developer guide for additional guidance on testing your change.

@dylanw-oss dylanw-oss requested a review from memoryz January 31, 2023 07:45
@dylanw-oss
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2023

Codecov Report

Merging #1816 (e787867) into master (fb47138) will decrease coverage by 10.76%.
The diff coverage is 71.42%.

@@             Coverage Diff             @@
##           master    #1816       +/-   ##
===========================================
- Coverage   86.80%   76.04%   -10.76%     
===========================================
  Files         295      295               
  Lines       15387    15396        +9     
  Branches      777      794       +17     
===========================================
- Hits        13356    11708     -1648     
- Misses       2031     3688     +1657     
Impacted Files Coverage Δ
.../azure/synapse/ml/causal/ResidualTransformer.scala 89.18% <70.00%> (-4.57%) ⬇️
...ft/azure/synapse/ml/causal/DoubleMLEstimator.scala 91.46% <75.00%> (-0.85%) ⬇️
...m/src/main/scala/com/microsoft/lightgbm/SWIG.scala 0.00% <0.00%> (-100.00%) ⬇️
...pse/ml/lightgbm/params/ClassifierTrainParams.scala 0.00% <0.00%> (-100.00%) ⬇️
...e/synapse/ml/lightgbm/StreamingPartitionTask.scala 0.00% <0.00%> (-97.11%) ⬇️
...zure/synapse/ml/lightgbm/dataset/SampledData.scala 0.00% <0.00%> (-90.00%) ⬇️
...ure/synapse/ml/cognitive/speech/AudioStreams.scala 0.00% <0.00%> (-87.88%) ⬇️
...e/synapse/ml/cognitive/search/AzureSearchAPI.scala 2.59% <0.00%> (-87.02%) ⬇️
...azure/synapse/ml/lightgbm/LightGBMClassifier.scala 10.75% <0.00%> (-80.65%) ⬇️
...zure/synapse/ml/cognitive/search/AzureSearch.scala 9.28% <0.00%> (-77.86%) ⬇️
... and 57 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dylanw-oss
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dylanw-oss
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

mhamilton723
mhamilton723 previously approved these changes Jan 31, 2023
@dylanw-oss
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723 mhamilton723 merged commit eb40372 into microsoft:master Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants