-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add aisample time series forecasting #1614
Conversation
Hey @lhrotk 👋! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this great PR Cruise, it looks pretty tight! Leaving comments below
- It looks like there is a few thousand lines of data still in the notebook (see the raw representation) could you please remove this so we can have small diffs that are viewable in UX?
- Mentioned this to Tan too, if you want we can make this notebook run on all platforms by using the synapseml public blob to host data.
Thanks so much for your feedback, Mark. I have deleted redundant lines in notebook metadata and now it is comparable. I will discuss with him on making this notebook available to all platforms. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #1614 +/- ##
==========================================
- Coverage 83.77% 78.87% -4.90%
==========================================
Files 292 292
Lines 15473 15473
Branches 752 752
==========================================
- Hits 12963 12205 -758
- Misses 2510 3268 +758
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@lhrotk, looks like we need to stop the notebook converter from picking this folder up. You think you have the cycles to try this fix? @serena-ruan will be able to advise on what needs to change here. You can repro this locally with the |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Related Issues/PRs
None
What changes are proposed in this pull request?
Add time series forecasting notebook for aisample under notebooks/community/aisample.
How is this patch tested?
Does this PR change any dependencies?
Does this PR add a new feature? If so, have you added samples on website?
website/docs/documentation
folder.Make sure you choose the correct class
estimators/transformers
and namespace.DocTable
points to correct API link.yarn run start
to make sure the website renders correctly.<!--pytest-codeblocks:cont-->
before each python code blocks to enable auto-tests for python samples.WebsiteSamplesTests
job pass in the pipeline.AB#1928947